implement TX v4 experimental #1201
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcchavezs
reviewed
Nov 6, 2024
| "github.com/corazawaf/coraza/v3/types" | ||
| ) | ||
|
|
||
| type Transaction interface { |
There was a problem hiding this comment.
IMHO this interface is meaningless, if someone wants to access this fields they can create their own convenience interface.
There was a problem hiding this comment.
package test
import (
"context"
"testing"
"github.com/corazawaf/coraza/v3"
"github.com/corazawaf/coraza/v3/types"
)
type transaction interface {
types.Transaction
Context() context.Context
}
func TestCoraza(t *testing.T) {
waf, _ := coraza.NewWAF(coraza.NewWAFConfig())
tx, ok := waf.NewTransaction().(transaction)
if !ok {
t.Errorf("cannot access Token")
}
tx.Context().Value("key")
}It is not possible to access internal fields using this hack
Context IS required to control timeout for certain actions, among others
jcchavezs
reviewed
Nov 6, 2024
| @@ -1576,6 +1576,14 @@ func (tx *Transaction) String() string { | |||
| return res.String() | |||
| } | |||
|
|
|||
| func (tx *Transaction) UnixTimestamp() int64 { | |||
There was a problem hiding this comment.
This is controversial and that is why I'd like to use use cases before exposing this. Why not a time.Time? Not saying that is the answer, just saying we need concrete use cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that you've checked the boxes below before you submit PR:
Thanks for your contribution ❤️